Remove the using for Microsoft.Build.Locator in NuGet.CommandLine.XPlat #4777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
previously approved these changes
Aug 30, 2022
donnie-msft
changed the title
donnie-msft
force-pushed
the
dev-donnie-msft-msbuildLocatorUsingStmt
branch
from
a3777ae to
799206a
Compare
donnie-msft
changed the title
donnie-msft
changed the title
zivkan
approved these changes
Aug 30, 2022
jeffkl
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/1833
Regression? Last working version:
Description
Missed this in previous PR, #4761
Only Debug builds would break, so CI is fine. Local
build.ps1runs will fail temporarily until this is merged.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation